linux-kernel - Re: [patch] srat, x86_64: Add support for nodes spanning other nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 25 Mar 2008 13:28:53 -0400
From:	Chris Snook <csnook@...hat.com>
To:	Suresh Siddha <suresh.b.siddha@...el.com>
CC:	mingo@...e.hu, hpa@...or.com, tglx@...utronix.de,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [patch] srat, x86_64: Add support for nodes spanning other nodes

Suresh Siddha wrote:
> For example, If the physical address layout on a two node system with 8 GB
> memory is something like:
> node 0: 0-2GB, 4-6GB
> node 1: 2-4GB, 6-8GB
> 
> Current kernels fail to boot/detect this NUMA topology.
> 
> ACPI SRAT tables can expose such a topology which needs to be supported.
> 
> Signed-off-by: Suresh Siddha <suresh.b.siddha@...el.com>
> ---
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 227fdb0..99eb102 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -880,6 +880,15 @@ config X86_64_ACPI_NUMA
>  	help
>  	  Enable ACPI SRAT based node topology detection.
>  
> +# Some NUMA nodes have memory ranges that span
> +# other nodes.  Even though a pfn is valid and
> +# between a node's start and end pfns, it may not
> +# reside on that node.  See memmap_init_zone()
> +# for details.
> +config NODES_SPAN_OTHER_NODES
> +	def_bool y
> +	depends on X86_64_ACPI_NUMA
> +

Is this hunk a leftover from your testing?  You're not using the config option 
anywhere, and there isn't really anything in this patch that would justify 
making this a separate config option in mainline.

-- Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/