linux-kernel - Re: [PATCH 109/148] include/asm-x86/serial.h: checkpatch cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 26 Mar 2008 11:56:28 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	David Miller <davem@...emloft.net>
Cc:	joern@...fs.org, jirislaby@...il.com, viro@...IV.linux.org.uk,
	joe@...ches.com, tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 109/148] include/asm-x86/serial.h: checkpatch cleanups
	- formatting only

* David Miller <davem@...emloft.net> wrote:

> From: Ingo Molnar <mingo@...e.hu>
> Date: Tue, 25 Mar 2008 14:45:56 +0100
> 
> > and let me give an example with the your very own code that you wrote 
> > and maintain, drivers/mtd/devices/block2mtd.c:
> > 
> >                                     errors   lines of code   errors/KLOC
> > drivers/mtd/devices/block2mtd.c         10             490          20.4
> 
> Ingo, this is devolving into a "code I maintain is great, code you 
> maintain sucks, checkpatch says so" kind of discussion, please stop.

Firstly, had you read my previous mails you'd realize that a score of 
20.4 errors/KLOC is pretty clean code for a driver. (and a manual view 
of drivers/mtd/devices/block2mtd.c confirmed that first quick 
impression.)

Secondly, it was you who claimed that checkpatch.pl warnings were bogus, 
i asked for hard data which you refused to provide, so i had to come up 
with examples to counter that.

What did you expect me to express my checkpatch.pl experience about, if 
not about code that i maintain? How did you expect me to show to you 
that the warnings are correct, if not code that you maintain? Why should 
i talk about any code that neither you nor i am directly interested in? 
Do you want me to talk about FreeBSD, so that i dont hurt anyone's 
feelings? Feel free to use my code as an example to make your points.

> You're not making any friends by making your arguments this way.

just to make it clear, i'm not here on lkml to "make friends", i'm here 
to make Linux better. The two goals are not fundamentally incompatible 
but sometimes they do clash ;-)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/