linux-kernel - [PATCH] x86: GEODE: add missing module.h include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 26 Mar 2008 14:13:01 -0400
From:	Andres Salomon <dilinger@...ued.net>
To:	Jordan Crouse <jordan.crouse@....com>
Cc:	Stefan Pfetzing <dreamind@...amind.de>,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	mingo@...hat.com, hpa@...or.com,
	Thomas Gleixner <tglx@...utronix.de>
Subject: [PATCH] x86: GEODE: add missing module.h include

On Wed, 26 Mar 2008 11:56:22 -0600
Jordan Crouse <jordan.crouse@....com> wrote:

> On 26/03/08 14:31 +0100, Stefan Pfetzing wrote:
> > Hello Jordan,
> >
> > I just tried to build your geodwdt driver for the geode watchdog. Therefore 
> > I pulled your repository from http://git.infradead.org/geode.git (or more, 
> > the git url).
> >
> > I tried to build the geodewdt driver as a module - which didn't work, and 
> > it failed with the same problem as earlier mentioned on lkmk [1]. I also 
> > checked the fix [2], but that seems to be already in your (or linus) tree - 
> > and so I'm unsure what the problem is.
> >
> > [1] http://kerneltrap.org/mailarchive/linux-kernel/2008/2/17/884074
> > [2] http://kerneltrap.org/mailarchive/linux-kernel/2008/2/17/884174
> >
> > Building directly into the kernel seems to work.
> >
> > Maybe you have some idea?
> 
> Hmm - that is strange.  Exporting the symbols should work.  I recommend
> starting over with a clean tree.
> 
> CCing Andres - any thoughts?
> 
> Jordan
> 


Er, yeah.  The patch below should fix it.  This should probably go into
2.6.25.





Oops, EXPORT_SYMBOL_GPL wasn't being declared due to this header
being missing.

Signed-off-by: Andres Salomon <dilinger@...ian.org>
---
 arch/x86/kernel/mfgpt_32.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/mfgpt_32.c b/arch/x86/kernel/mfgpt_32.c
index 3f0f603..2c0e6b5 100644
--- a/arch/x86/kernel/mfgpt_32.c
+++ b/arch/x86/kernel/mfgpt_32.c
@@ -30,6 +30,7 @@
 
 #include <linux/kernel.h>
 #include <linux/interrupt.h>
+#include <linux/module.h>
 #include <asm/geode.h>
 
 static struct mfgpt_timer_t {
-- 
1.5.3.7

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/