linux-kernel - Re: style of function definitions (Re: [patch] bkl2mtd: cleanup)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 31 Mar 2008 04:37:41 +0100
From:	"Oleg Verych" <olecom@...il.com>
To:	"Jan Engelhardt" <jengelh@...putergmbh.de>
Cc:	"Oleg Verych" <olecom@...wer.upol.cz>,
	"Ingo Molnar" <mingo@...e.hu>, "Al Viro" <viro@...iv.linux.org.uk>,
	"Joern Engel" <joern@...fs.org>,
	"David Miller" <davem@...emloft.net>, jirislaby@...il.com,
	joe@...ches.com, tglx@...utronix.de, linux-kernel@...r.kernel.org,
	"Andy Whitcroft" <apw@...dowen.org>
Subject: Re: style of function definitions (Re: [patch] bkl2mtd: cleanup)

Jan Engelhardt @ Sun, Mar 30, 2008 at 6:31 AM:

>  > No matter what coding style is, the winner is "linux-2.6/fs/xfs", and
>  > i doubt anyone can fix that :)
>
>  They at least have an excuse of having a historical unix background :)

i.e. zoo of proprietary versions, expensive, without reliable implementation
of basic tools and compilers, etc.

Historical UNIX(R) isn't that good at all. Now it's POSIX(R) forcing all
new development back.

http://kernelnewbies.org/olecom#trailing_comments_crap
http://kernelnewbies.org/olecom#trailing_multiline_comments_crap

Q: why every parameter is on new line?
A: thus we have more actual code line count

Q: why trailing comments on every parameter?
A: our C compiler have (had) 8 characters limit for variable names

Q: don't you think streaming editor can handle that?
A: our tools have not such thing

Q: you have multi-line trailing comments there, don't you know
   it complicates line-oriented grep-like text processing?
   why don't you write freely in comment block before function definition?
A: why do you care?

-- 
-o--=O`C
 #oo'L O
<___=E M
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/