[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 4 Apr 2008 11:24:07 +0100
From: Ralf Baechle <ralf@...ux-mips.org>
To: Christoph Lameter <clameter@....com>
Cc: Sam Ravnborg <sam@...nborg.org>,
Andrew Morton <akpm@...ux-foundation.org>,
dmitri.vorobiev@...il.com, linux-kernel@...r.kernel.org
Subject: Re: 2.6.25-rc8-mm1 (mips build failure)
On Thu, Apr 03, 2008 at 03:17:22PM -0700, Christoph Lameter wrote:
> > The reason for MIPS doing things a little different is that the resulting
> > <asm/asm-offsets.h> doesn't look like machine generated jibberish. So
> > how about below patch which combines the two sed expressions.
>
> Well but it is machine generated and it may be best if mips would do more
> of the same that is done in other arches? We do not want special arch
> cases in Kbuild.
>
> How about this patch?
Almost. It compiles into a usable header but breaks the text() macro
which is used to emit a commit (actually any string literal) into the
output:
> #define text(t) __asm__("\n@@@" t)
> void output_ptreg_defines(void)
> {
> text("/* MIPS pt_regs offsets. */");
With your patch nothing will be emited. The existing non-MIPS sed
expression in Kbuild doesn't allow for that which is why I added the
handling of @@@-prefixed strings to the sed expression. And once that
is there the remaining asm-offset.c change is no longer needed.
Ralf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists