[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 4 Apr 2008 13:46:09 +0200
From: Jens Axboe <jens.axboe@...cle.com>
To: Hugh Dickins <hugh@...itas.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Linus Torvalds <torvalds@...ux-foundation.org>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] splice: use mapping_gfp_mask
On Thu, Apr 03 2008, Hugh Dickins wrote:
> The loop block driver is careful to mask __GFP_IO|__GFP_FS out of its
> mapping_gfp_mask, to avoid hangs under memory pressure. But nowadays
> it uses splice, usually going through __generic_file_splice_read. That
> must use mapping_gfp_mask instead of GFP_KERNEL to avoid those hangs.
>
> Signed-off-by: Hugh Dickins <hugh@...itas.com>
> ---
> Ought to go into 2.6.25. For 2.6.23 and 2.6.24 stable? Well, I've
> not actually seen this hang on any of these, though presumably it's
> lurking there. Where I did see it, and test the fix, was 2.6.25-rc5-mm1:
> whose SLUB had a disturbing predilection (since corrected) for order-4
> allocations, even when allocating radix tree nodes.
Thanks Hugh, definitely correct! I see it's already merged, so all is
well.
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists