linux-kernel - Re: Fix "buggy BIOS check" when CPUs are hot removed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 07 Apr 2008 11:55:00 -0700
From:	Alok Kataria <akataria@...are.com>
To:	len.brown@...el.com
Cc:	rui.zhang@...el.com, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org, Daniel Arai <arai@...are.com>,
	Zachary Amsden <zach@...are.com>
Subject: Re: Fix "buggy BIOS check" when CPUs are hot removed

This patch too seems malformed. Resending and also find attached.

Thanks,
Alok

--
Fix "buggy BIOS check" when CPUs are hot added and removed

processor_device_array[pr->id] needs to be set to NULL when removing a
CPU. Else the "buggy BIOS check" in acpi_processor_start mistakenly
fires when a CPU is removed from the system and then later re-added.

Signed-off-by: Alok N Kataria <akataria@...are.com>
Signed-off-by: Dan Arai <arai@...are.com>

---
 drivers/acpi/processor_core.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/acpi/processor_core.c
b/drivers/acpi/processor_core.c
index 61450f4..0f95f26 100644
--- a/drivers/acpi/processor_core.c
+++ b/drivers/acpi/processor_core.c
@@ -828,6 +828,7 @@ static int acpi_processor_remove(struct acpi_device
*device, int type)
 	}
 
 	processors[pr->id] = NULL;
+	processor_device_array[pr->id] = NULL;
 
 	kfree(pr);
 
-- 
1.5.4




On Fri, 2008-04-04 at 16:48 -0700, Alok Kataria wrote:
> Fixes a BUG in ACPI hotplugging.
> 
> processor_device_array[pr->id] needs to be set to NULL when removing a
> CPU. Else the "buggy BIOS check" in acpi_processor_start mistakenly
> fires when a CPU is removed from the system and then later re-added.
> 
> Signed-off-by: Alok N Kataria <akataria@...are.com>
> Signed-off-by: Dan Arai <arai@...are.com>
> 
> ---
> drivers/acpi/processor_core.c |    1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/acpi/processor_core.c
> b/drivers/acpi/processor_core.c
> index 61450f4..0f95f26 100644
> --- a/drivers/acpi/processor_core.c
> +++ b/drivers/acpi/processor_core.c
> @@ -828,6 +828,7 @@ static int acpi_processor_remove(struct acpi_device
> *device, int type)
> }
> 
> processors[pr->id] = NULL;
> + processor_device_array[pr->id] = NULL;
> 
> kfree(pr);
> 

View attachment "buggy-bios-check-on-cpu-hotplug.patch" of type "text/x-patch" (859 bytes)