linux-kernel - Re: 2.6.25-rc8: FTP transfer errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Apr 2008 11:59:07 +0900 (JST)
From:	YOSHIFUJI Hideaki / 吉藤英明 
	<yoshfuji@...ux-ipv6.org>
To:	lkml@....ca, davem@...emloft.net
Cc:	jesper.juhl@...il.com, tilman@...p.cc, jeff@...zik.org,
	rjw@...k.pl, linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	xemul@...nvz.org, yoshfuji@...ux-ipv6.org
Subject: Re: 2.6.25-rc8: FTP transfer errors

In article <47FEB0E3.8080507@....ca> (at Thu, 10 Apr 2008 20:29:23 -0400), Mark Lord <lkml@....ca> says:

> David Miller wrote:
> > From: Mark Lord <lkml@....ca>
> > Date: Thu, 10 Apr 2008 20:16:11 -0400
> > 
> >> [c67499c0e772064b37ad75eb69b28fc218752636 is first bad commit
> >> commit c67499c0e772064b37ad75eb69b28fc218752636
> >> Author: Pavel Emelyanov <xemul@...nvz.org>
> >> Date:   Thu Jan 31 05:06:40 2008 -0800
> >>
> >>     [NETNS]: Tcp-v4 sockets per-net lookup.
> >>
> >>     Add a net argument to inet_lookup and propagate it further
> >>     into lookup calls. Plus tune the __inet_check_established.
> >>
> >>     The dccp and inet_diag, which use that lookup functions
> >>     pass the init_net into them.
> >>
> >>     Signed-off-by: Pavel Emelyanov <xemul@...nvz.org>
> >>     Signed-off-by: David S. Miller <davem@...emloft.net>
> > 
> > Thanks Mark.
> > 
> > Pavel can you take a look?  I suspect that the namespace
> > changes or gets NULL'd out somehow and this leads to the
> > resets because the socket can no longer be found.  Perhaps
> > it's even a problem with time-wait socket namespace
> > propagation.
> ..
> 
> My system here is now set up for quick/easy retest, if you have any
> suggestions or patches to try out.

Please try this, from net-2.6.26 tree.

Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>

----
>From 8d9f1744cab50acb0c6c9553be533621e01f178b Mon Sep 17 00:00:00 2001
From: Daniel Lezcano <dlezcano@...ibm.com>
Date: Fri, 21 Mar 2008 04:12:54 -0700
Subject: [PATCH] [NETNS][IPV6] tcp - assign the netns for timewait sockets

Copy the network namespace from the socket to the timewait socket.

Signed-off-by: Daniel Lezcano <dlezcano@...ibm.com>
Signed-off-by: David S. Miller <davem@...emloft.net>
---
 net/ipv4/inet_timewait_sock.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/net/ipv4/inet_timewait_sock.c b/net/ipv4/inet_timewait_sock.c
index 876169f..717c411 100644
--- a/net/ipv4/inet_timewait_sock.c
+++ b/net/ipv4/inet_timewait_sock.c
@@ -124,6 +124,7 @@ struct inet_timewait_sock *inet_twsk_alloc(const struct sock *sk, const int stat
 		tw->tw_hash	    = sk->sk_hash;
 		tw->tw_ipv6only	    = 0;
 		tw->tw_prot	    = sk->sk_prot_creator;
+		tw->tw_net          = sk->sk_net;
 		atomic_set(&tw->tw_refcnt, 1);
 		inet_twsk_dead_node_init(tw);
 		__module_get(tw->tw_prot->owner);
-- 
1.4.4.4

-- 
YOSHIFUJI Hideaki @ USAGI Project  <yoshfuji@...ux-ipv6.org>
GPG-FP  : 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/