linux-kernel - Re: [patch] checkpatch: relax spacing and line length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Apr 2008 06:24:20 +0200 (CEST)
From:	Jan Engelhardt <jengelh@...putergmbh.de>
To:	SL Baur <steve@...acs.org>
cc:	Benny Halevy <bhalevy@...asas.com>,
	Andy Whitcroft <apw@...dowen.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Randy Dunlap <rdunlap@...otime.net>,
	Richard Knutsson <ricknu-0@...dent.ltu.se>,
	Stefan Richter <stefanr@...6.in-berlin.de>
Subject: Re: [patch] checkpatch: relax spacing and line length


On Friday 2008-04-11 01:52, SL Baur wrote:
>On 4/9/08, Benny Halevy <bhalevy@...asas.com> wrote:
>
>>  In http://lkml.org/lkml/2008/2/26/533,
>>  SL Baur <steve <at> xemacs.org> said:
>>  > The proposed two space change is ugly.  Can someone NAK it?
>>
>>  I'm not sure what "two space change" proposal this Steve referred to
>>  and his rejection is based on not-to-sound aesthetic grounds.
>>
>>  The motivation behind our proposal is more than just aesthetic.
>>  I believe that using tabs for indent and then spaces for alignment
>>  is functionally better, works for everybody, and will eventually result
>>  in a more readable code over time, hopefully leading to fewer bugs.
>
>Tabs + a variable number spaces to match up logically with the
>previous line is O.K.  Tabs + exactly two spaces is what I objected
>to.  I only posted due to being the originator of the Linux Kernel Emacs
>cc-mode style and cc-mode works like the former.
>
>For whatever it's worth, my sentiments are on the David Miller side,
>having been the lucky recipient of format changes only patch bombs
>before.  I suppose you should be glad you don't have someone running
>a spell checker on the entire source code.

We have these people too. And by large, I find spell fixes
better than oh-I-decided-to-run-checkpatch-on-existing-code bombs.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/