linux-kernel - Re: [PATCH 3/7] omfs: add directory routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 13 Apr 2008 05:20:23 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Bob Copeland <me@...copeland.com>, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH 3/7] omfs: add directory routines

On Sun, Apr 13, 2008 at 10:11:44AM +0100, Alan Cox wrote:
> 
> > +static int omfs_readdir(struct file *filp, void *dirent, filldir_t filldir)
> > +{
> > +	struct inode *dir = filp->f_dentry->d_inode;
> > +	struct buffer_head *bh = NULL;
> 
> > +	if (filp->f_pos >> 32)
> > +		goto success;
> 
> f_pos may be 32bit in which case >> 32 does not have defined behaviour in
> C.

f_pos is always 64bit since 2.3.x

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/