linux-kernel - Re: [PATCH] sound/pci/rme9652/hdspm.c: stop inlining largish static functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 14 Apr 2008 12:28:27 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Denys Vlasenko <vda.linux@...glemail.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sound/pci/rme9652/hdspm.c: stop inlining largish static functions

At Tue, 1 Apr 2008 04:36:48 +0200,
Denys Vlasenko wrote:
> 
> Hi Takashi,
> 
> Can you please take a look at this patch?
> 
> sound/pci/rme9652/hdspm.c has unusually large number
> of static inline functions - 22.
> 
> I looked through them and some of them seem to be too big
> to warrant inlining.
> 
> This patch removes "inline" from these static functions
> (regardless of number of callsites - gcc nowadays auto-inlines
> statics with one callsite).
> 
> Size difference on 32bit x86:
>    text    data     bss     dec     hex filename
>   20437    2160     516   23113    5a49 linux-2.6-ALLYES/sound/pci/rme9652/hdspm.o
>   18036    2160     516   20712    50e8 linux-2.6.inline-ALLYES/sound/pci/rme9652/hdspm.o
> 
> Signed-off-by: Denys Vlasenko <vda.linux@...glemail.com>
> --
> vda

Thanks for the patch.  I applied it to ALSA tree together with coding
style fixes.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/