| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 15 Apr 2008 20:31:08 -0700 (PDT) From: David Miller <davem@...emloft.net> To: tonyb@...ernetics.com Cc: mcarlson@...adcom.com, herbert@...dor.apana.org.au, mchan@...adcom.com, netdev@...r.kernel.org, gregkh@...e.de, linux-kernel@...r.kernel.org Subject: Re: TG3 network data corruption regression 2.6.24/2.6.23.4 From: Tony Battersby <tonyb@...ernetics.com> Date: Tue, 15 Apr 2008 11:39:27 -0400 > Thanks, your patch fixes the problem (tested on 2.6.24.4). However, I > had to change "(skb->mac_header & 3)" in your patch to "((long) > skb->mac_header & 3)" since mac_header is a pointer rather than an int > on 32-bit systems. > > Tested-by: Tony Battersby <tonyb@...ernetics.com> Thanks for testing. Matt, skb->mac_header is either a pointer or an integer offset depending upon whether we are building 32-bit or 64-bit. Testing skb->mac_header is therefore wrong, because it's an offset from a pointer in the 64-bit case and therefore it's alignment does not indicate correctly the actual final alignment of skb->head + skb->max_header. Therefore you should test skb_mac_header(skb) and cast it with (unsigned long). Please respin this fix with that correction so I can apply it and get this bug fixed, thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists