linux-kernel - Re: [PATCH 01/15] ARM minor irq handler cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 19 Apr 2008 04:28:40 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Russell King <rmk+lkml@....linux.org.uk>
CC:	linux-arm-kernel@...ts.arm.linux.org.uk, kernel@...tstofly.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 01/15] ARM minor irq handler cleanups

Russell King wrote:
> On Fri, Apr 18, 2008 at 07:22:45PM -0400, Jeff Garzik wrote:
>> Avoid confusion by /not/ passing an unused pointer to
>> arm_rtc_interrupt()
>>
>> This change's main purpose is to prepare for the patchset in
>> jgarzik/misc-2.6.git#irq-remove, that explores removal of the
>> never-used 'irq' argument in each interrupt handler.
> 
> I don't see how these two things are connected.  Yes, it's true that
> this RTC driver doesn't use 'dev_id' but that's an entirely separate
> issue to removing the 'int irq' argument.
> 
> As I see it, this change is just unnecessarily adding to your workload
> for this patch set.

The added workload came from confusion created when I reviewed the code :)

Therefore I considered it better to have to less confusing version of 
the code in my tree for future reviews, and ideally have the less 
confusing version of the code in upstream as well.

I can remove the boilerplate paragraph from the patch description, if 
that's your main complaint.

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/