linux-kernel - Re: 2.6.25-mm1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 21 Apr 2008 13:07:59 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Joseph Fannin <jfannin@...il.com>,
	linux-kernel@...r.kernel.org, Greg KH <greg@...ah.com>,
	Kay Sievers <kay.sievers@...y.org>,
	Stas Sergeev <stsp@...et.ru>
Subject: Re: 2.6.25-mm1

[Added snd-pcsp author to Cc]

At Fri, 18 Apr 2008 21:29:34 -0700,
Andrew Morton wrote:
> 
> On Sat, 19 Apr 2008 00:14:29 -0400 Dmitry Torokhov <dmitry.torokhov@...il.com> wrote:
> 
> > On Fri, Apr 18, 2008 at 08:02:37PM -0700, Andrew Morton wrote:
> > > On Fri, 18 Apr 2008 22:13:43 -0400 Joseph Fannin <jfannin@...il.com> wrote:
> > > 
> > > > On Fri, Apr 18, 2008 at 01:47:57AM -0700, Andrew Morton wrote:
> > > > >
> > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.25/2.6.25-mm1/ 
> > > > 
> > > > I've been seeing the following backtraces since 2.6.25-rc8-mm1 -- at
> > > > least, since that's the earliest -mm I've built in a while.  I don't
> > > > get the same in mainline.
> > > > 
> > > > No idea who to CC:
> > > 
> > > I have a few ideas.
> > > 
> > > >  I've sat on this report long enough.
> > > 
> > > Thanks for the report.
> > > 
> > > > I'm going to send a few different reports in separate mails, so I'll
> > > > put my dmesg and .config up on a server:
> > > > 
> > > > http://home.columbus.rr.com/jfannin3/dmesg.txt
> > > > http://home.columbus.rr.com/jfannin3/config-2.6.25-mm1.txt
> > > > 
> > > > [  451.915553] sysfs: duplicate filename 'pcspkr' can not be created
> > > > [  451.915731] ------------[ cut here ]------------
> > > > [  451.915851] WARNING: at fs/sysfs/dir.c:427 sysfs_add_one+0x85/0xe0()
> > > > [  451.915981] Modules linked in: snd_pcsp(+) ac97_bus snd_pcm_oss snd_mixer_oss snd_pcm snd_mpu401_uart snd_seq_dummy snd_seq_oss snd_seq_midi psmouse snd_rawmidi serio_raw snd_seq_midi_event snd_seq button i2c_viapro snd_timer snd_seq_device pcspkr i2c_core snd snd_page_alloc via686a shpchp pci_hotplug parport_pc parport via_agp agpgart soundcore evdev sg sr_mod cdrom sd_mod 8139cp aic7xxx  scsi_transport_spi scsi_mod 8139too mii uhci_hcd usbcore raid10 raid456 async_xor async_memcpy async_tx xor raid1 raid0 multipath linear md_mod thermal processor fan fuse ext4dev mbcache jbd2 crc16
> > > > [  451.918960] Pid: 2740, comm: modprobe Tainted: G        W 2.6.25-mm1 #7
> > > > [  451.929271]  [<c0130fa9>] warn_on_slowpath+0x59/0x80
> > > > [  451.929500]  [<c0132400>] ? vprintk+0x2f0/0x4a0
> > > > [  451.929723]  [<c0356adc>] ? _spin_unlock+0x2c/0x50
> > > > [  451.929918]  [<c01c6a7a>] ? ifind+0x4a/0xa0
> > > > [  451.930126]  [<c0155216>] ? trace_hardirqs_on_caller+0x16/0x150
> > > > [  451.930334]  [<c015535b>] ? trace_hardirqs_on+0xb/0x10
> > > > [  451.930534]  [<c01325d0>] ? printk+0x20/0x30
> > > > [  451.930727]  [<c01fcc45>] sysfs_add_one+0x85/0xe0
> > > > [  451.930900]  [<c01fd89e>] create_dir+0x4e/0xb0
> > > > [  451.931064]  [<c01fd930>] sysfs_create_dir+0x30/0x50
> > > > [  451.931291]  [<c0356adc>] ? _spin_unlock+0x2c/0x50
> > > > [  451.931485]  [<c023dac6>] kobject_add_internal+0xb6/0x190
> > > > [  451.931656]  [<c023dc22>] ? kobject_set_name_vargs+0x32/0x40
> > > > [  451.931857]  [<c023dc8a>] kobject_add_varg+0x5a/0x60
> > > > [  451.932022]  [<c023e12f>] kobject_init_and_add+0x2f/0x40
> > > > [  451.932188]  [<c02a3e44>] bus_add_driver+0x94/0x250
> > > > [  451.932364]  [<c02a5062>] driver_register+0x42/0xf0
> > > > [  451.932533]  [<c02a6c56>] platform_driver_register+0x66/0x70
> > > > [  451.932702]  [<cc04b02a>] pcsp_init+0x2a/0x2c [snd_pcsp]
> > > > [  451.932877]  [<c015e137>] sys_init_module+0x87/0x1a0
> > > > [  451.933043]  [<c0155216>] ? trace_hardirqs_on_caller+0x16/0x150
> > > > [  451.933246]  [<c024314c>] ? trace_hardirqs_on_thunk+0xc/0x10
> > > > [  451.933453]  [<c0104077>] sysenter_past_esp+0x78/0xc5

Seems that snd-pcsp registers as "pcspkr", which is identical with
input pc-speaker driver.  Does the patch below fix the problem?


Takashi

---
diff -r e8f61dd0b153 sound/drivers/pcsp/pcsp.c
--- a/sound/drivers/pcsp/pcsp.c	Thu Apr 17 17:58:34 2008 +0200
+++ b/sound/drivers/pcsp/pcsp.c	Mon Apr 21 13:06:35 2008 +0200
@@ -21,7 +21,7 @@
 MODULE_DESCRIPTION("PC-Speaker driver");
 MODULE_LICENSE("GPL");
 MODULE_SUPPORTED_DEVICE("{{PC-Speaker, pcsp}}");
-MODULE_ALIAS("platform:pcspkr");
+MODULE_ALIAS("platform:snd_pcsp");
 
 static int index = SNDRV_DEFAULT_IDX1;	/* Index 0-MAX */
 static char *id = SNDRV_DEFAULT_STR1;	/* ID for this card */
@@ -214,7 +214,7 @@
 
 static struct platform_driver pcsp_platform_driver = {
 	.driver		= {
-		.name	= "pcspkr",
+		.name	= "snd_pcsp",
 		.owner	= THIS_MODULE,
 	},
 	.probe		= pcsp_probe,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/