linux-kernel - Re: [PATCH] cgroup: use read lock to guard find_existing_css

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 22 Apr 2008 23:48:28 -0700
From:	"Paul Menage" <menage@...gle.com>
To:	"Li Zefan" <lizf@...fujitsu.com>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"Linux Containers" <containers@...ts.linux-foundation.org>
Subject: Re: [PATCH] cgroup: use read lock to guard find_existing_css_set()

On Tue, Apr 22, 2008 at 8:04 PM, Li Zefan <lizf@...fujitsu.com> wrote:
> The function does not modify anything (except the temporary
>  css template), so it's sufficient to hold read lock.
>
>  Signed-off-by: Li Zefan <lizf@...fujitsu.com>

Acked-by: Paul Menage <menage@...gle.com>

Thanks.

>  ---
>   kernel/cgroup.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
>  diff --git a/kernel/cgroup.c b/kernel/cgroup.c
>  index 2727f92..e9eb5da 100644
>  --- a/kernel/cgroup.c
>  +++ b/kernel/cgroup.c
>  @@ -406,11 +406,11 @@ static struct css_set *find_css_set(
>
>         /* First see if we already have a cgroup group that matches
>          * the desired set */
>  -       write_lock(&css_set_lock);
>  +       read_lock(&css_set_lock);
>         res = find_existing_css_set(oldcg, cgrp, template);
>         if (res)
>                 get_css_set(res);
>  -       write_unlock(&css_set_lock);
>  +       read_unlock(&css_set_lock);
>
>         if (res)
>                 return res;
>  -- 1.5.4.rc3
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/