linux-kernel - Re: [PATCH] m32r: test before subtraction on unsigned relocation range

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 25 Apr 2008 11:36:18 +0900
From:	Hirokazu Takata <takata@...ux-m32r.org>
To:	Roel Kluin <12o3l@...cali.nl>
Cc:	takata@...ux-m32r.org, linux-m32r@...linux-m32r.org,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] m32r: test before subtraction on unsigned relocation range

From: Roel Kluin <12o3l@...cali.nl>
Subject: [PATCH] m32r: test before subtraction on unsigned relocation range
Date: Wed, 23 Apr 2008 18:34:16 +0200
>  		case R_M32R_26_PCREL_RELA:
> -	  		relocation = (relocation - (Elf32_Addr) location);
> -			if (relocation < -0x2000000 || 0x1fffffc < relocation)
> +			if (relocation + 0x20000 < (Elf32_Addr) location ||
> +					relocation >= 0x1fffc + (Elf32_Addr) location)

A slight fix is required.

The above range check is incorrect, because the R_M32R_26_PCREL_RELA is
26-bit relocation.

-- Takata
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/