linux-kernel - Re: [PATCH] sched: add statics, don't return void expressions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 25 Apr 2008 10:56:51 -0700
From:	Harvey Harrison <harvey.harrison@...il.com>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:	Ingo Molnar <mingo@...e.hu>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sched: add statics, don't return void expressions

On Fri, 2008-04-25 at 14:17 +0200, Peter Zijlstra wrote:
> On Thu, 2008-04-24 at 18:17 -0700, Harvey Harrison wrote:
> > Noticed by sparse:
> > kernel/sched.c:760:20: warning: symbol 'sched_feat_names' was not declared. Should it be static?
> > kernel/sched.c:767:5: warning: symbol 'sched_feat_open' was not declared. Should it be static?
> > kernel/sched_fair.c:845:3: warning: returning void-valued expression
> > kernel/sched.c:4386:3: warning: returning void-valued expression
> 
> I'm still of two minds about that latter warning, I think:
> 
> void foo(void);
> 
> void bar(void)
> {
> 	return foo();
> }
> 
> isn't wrong, as the return types match.
> 

True it's not wrong, but it is a trivial way to reduce the sparse noise
somewhat which can make it harder to see real bugs.  Just like the
integer used as NULL pointer warnings.

And even though in this case, I can't see the return type changing to
actually return something, coding it this way makes it obvious if you
ever missed a return site.

No strong feelings.

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/