linux-kernel - Re: CONFIG_OPTIMIZE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 27 Apr 2008 02:26:00 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	David Miller <davem@...emloft.net>, linux-kernel@...r.kernel.org,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	viro@...IV.linux.org.uk
Subject: Re: CONFIG_OPTIMIZE_INLINING

On Sun, Apr 27, 2008 at 07:59:43AM +0200, Ingo Molnar wrote:
> here, two months ago:
> 
>   http://lkml.org/lkml/2008/3/3/122
> 
> i made it x86-only due to this FUD that went against it:
> 
>   "messing with a global #define in a way that the results on 24 
>    architectures with 7 different releases of gcc would be 
>    unpredictable."
> 
> ... as i saw no reason why this feature, which i found rather useful, 
> should be delayed another year or so. I'd be more than happy to promote 
> this feature back to lib/Kconfig.debug, sparc64 interest would make that 
> a strong argument.
> 
> and here is the pull request that i posted to lkml, with the full patch 
> included as well:
> 
>   http://www.gossamer-threads.com/lists/linux/kernel/911104?page=last

This still does not explain why it's two commits.   It also doesn't
explain the horrible cpp and ifdef abuse in there - having a config
symbol in one architecture only and then a cpp symbol to prevent the ill
effects of it in one signle architecture is simply utterly braindead,
sorry.

This kind of thing should be discussed at least on linux-arch and input
from at least partially wise people would have led too a much better
solution.  Like, umm moving the option to a global config file and let
the architecture default it to y/n where needed.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/