linux-kernel - Re: [PATCH] ehca: ret is unsigned, ibmebus_request_irq() negative return ignored in hca_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 28 Apr 2008 18:36:20 +0200
From:	Hoang-Nam Nguyen <HNGUYEN@...ibm.com>
To:	Roel Kluin <12o3l@...cali.nl>
Cc:	Christoph Raisch <raisch@...ibm.com>,
	general@...ts.openfabrics.org, lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ehca: ret is unsigned, ibmebus_request_irq() negative return
 ignored in hca_create_eq()

Hello Roel!
Thanks for pointing this out.
Will send another version with a more consistent naming convention
for return variable from firmware. We used to naming it h_ret.
Regards
Nam

Roel Kluin <12o3l@...cali.nl> wrote on 23.04.2008 23:07:53:

> diff --git a/drivers/infiniband/hw/ehca/ehca_eq.c
> b/drivers/infiniband/hw/ehca/ehca_eq.c
> index b4ac617..9727235 100644
> --- a/drivers/infiniband/hw/ehca/ehca_eq.c
> +++ b/drivers/infiniband/hw/ehca/ehca_eq.c
> @@ -59,6 +59,7 @@ int ehca_create_eq(struct ehca_shca *shca,
>     u32 i;
>     void *vpage;
>     struct ib_device *ib_dev = &shca->ib_device;
> +   int ret2;
>
>     spin_lock_init(&eq->spinlock);
>     spin_lock_init(&eq->irq_spinlock);
> @@ -123,18 +124,18 @@ int ehca_create_eq(struct ehca_shca *shca,
>
>     /* register interrupt handlers and initialize work queues */
>     if (type == EHCA_EQ) {
> -      ret = ibmebus_request_irq(eq->ist, ehca_interrupt_eq,
> +      ret2 = ibmebus_request_irq(eq->ist, ehca_interrupt_eq,
>                   IRQF_DISABLED, "ehca_eq",
>                   (void *)shca);
> -      if (ret < 0)
> +      if (ret2 < 0)
>           ehca_err(ib_dev, "Can't map interrupt handler.");
>
>        tasklet_init(&eq->interrupt_task, ehca_tasklet_eq, (long)shca);
>     } else if (type == EHCA_NEQ) {
> -      ret = ibmebus_request_irq(eq->ist, ehca_interrupt_neq,
> +      ret2 = ibmebus_request_irq(eq->ist, ehca_interrupt_neq,
>                   IRQF_DISABLED, "ehca_neq",
>                   (void *)shca);
> -      if (ret < 0)
> +      if (ret2 < 0)
>           ehca_err(ib_dev, "Can't map interrupt handler.");
>
>        tasklet_init(&eq->interrupt_task, ehca_tasklet_neq, (long)shca);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/