linux-kernel - Re: [patch] pcspkr: fix dependancies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Apr 2008 16:19:25 -0400
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	Stas Sergeev <stsp@...et.ru>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Takashi Iwai <tiwai@...e.de>,
	Linux kernel <linux-kernel@...r.kernel.org>,
	Vojtech Pavlik <vojtech@...e.cz>,
	Michael Opdenacker <michael@...e-electrons.com>,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [patch] pcspkr: fix dependancies

On Mon, Apr 28, 2008 at 10:12:25PM +0200, Sam Ravnborg wrote:
> On Mon, Apr 28, 2008 at 03:58:56PM -0400, Dmitry Torokhov wrote:
> > On Mon, Apr 28, 2008 at 11:34:14PM +0400, Stas Sergeev wrote:
> > > Hello.
> > > 
> > > Dmitry Torokhov wrote:
> > > > It looks like the change was introduced by commit
> > > > 67926892ef7a7fbc76de607120d44416019fdf07
> > > Indeed. But the log message
> > > http://www.mail-archive.com/git-commits-head@vger.kernel.org/msg36026.html
> > > doesn't seem to specify the reason
> > > for the change, so this doesn't
> > > clarify a thing, unfortunately.
> > > 
> > > > I think that we should register devices even if there is no driver in
> > > > the kernel for it because driver may be compiled at later time or be out
> > > > of tree. Adding patch author and other people that signed off the patch
> > > > to CC...
> > > Since there seem to be no objections,
> > > would you mind adding the patch to your
> > > git tree? Or who should that be?
> > 
> > I try to stay within drivers/input boundaries ;) Ingo I think is the
> > person you need.
> If you google you will find a long thread about this patch.
> It is all about saving memory for embedded platforms.
> No need to have the driver if there is no speaker on the board.
> 

The patch does it backwards though - it disables platform device if
there is no driver. We don't stop enumerating PCI devices if some of
them don't have a driver for them, do we? The arch code should not
create the device if it knows that the boards does not have it.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/