linux-kernel - Re: [PATCH] x86: !x & y typo in mtrr code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 30 Apr 2008 09:46:11 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Björn Steinbrink <B.Steinbrink@....de>
cc:	Ingo Molnar <mingo@...e.hu>, Al Viro <viro@...IV.linux.org.uk>,
	Harvey Harrison <harvey.harrison@...il.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	LKML <linux-kernel@...r.kernel.org>,
	"Pallipadi, Venkatesh" <venkatesh.pallipadi@...el.com>
Subject: Re: [PATCH] x86: !x & y typo in mtrr code

On Wed, 30 Apr 2008, Björn Steinbrink wrote:
> On 2008.04.29 23:04:35 +0200, Ingo Molnar wrote:
> > 
> > * Al Viro <viro@...IV.linux.org.uk> wrote:
> > 
> > > On Sat, Apr 26, 2008 at 09:00:17PM -0700, Harvey Harrison wrote:
> > > > As written, this can never be true.
> > > 
> > > ... and introduced through x86.git, of all things...  May I suggest 
> > > that in addition to all-important whitespace hunting something that 
> > > catches lowly real bugs would also be run over that tree?  sparse 
> > > *does* catch that...
> > 
> > firstly, it _was_ caught via Sparse, ...
> 
> But that is exactly Al's point. Had you run sparse over your tree
> _before_ it got pulled by Linus, that bug should have never made it into
> mainline.

sparse builds are on the way to the automated build framework
already. won't happen again.

Thanks,
	tglx