linux-kernel - Re: linux-next: xfs build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 30 Apr 2008 16:35:44 +1000
From:	David Chinner <dgc@....com>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	David Chinner <dgc@....com>, linux-next@...r.kernel.org,
	xfs-masters@....sgi.com, Christoph Hellwig <hch@...radead.org>,
	Lachlan McIlroy <lachlan@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	Linus <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: linux-next: xfs build failure

On Wed, Apr 30, 2008 at 02:00:27PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> Today's linux-next build (powerpc ppc64_defconfig) fails like this:
> 
> fs/xfs/xfs_ialloc.c: In function 'xfs_ialloc_ag_alloc':
> fs/xfs/xfs_ialloc.c:301: error: implicit declaration of function 'random32'
> 
> I added
> 
> #include <linux/random.h>
> 
> after the other includes in fs/xfs/xfs_ialloc.c, but there is probably a
> better fix.
> 
> The commit that seems to have caused this
> 6309a0720469beb77e0ab75f403a98a0aba4140c ("XFS] Don't initialise new
> inode generation numbers to zero") in the xfs tree that I have seems to
> have just gone into Linus' tree as commit
> 359346a9655c8800408ed3ca44517ac7ea95c197.

Ah, I see the problem - a CONFIG_XFS_DEBUG build includes linux/random.h
in a debug header file. That's probably why I didn't catch it (I need to
check the .config on my build test tree).

I'll get it fixed properly, but in the mean time the include you've got
there will suffice...

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/