linux-kernel - Re: [PATCH 50/56] microblaze_v2: setup.h string.h thread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 05 May 2008 12:39:28 +1000
From:	John Williams <john.williams@...alogix.com>
To:	monstr@...nam.cz
Cc:	linux-kernel@...r.kernel.org, arnd@...db.de,
	linux-arch@...r.kernel.org, stephen.neuendorffer@...inx.com,
	John.Linn@...inx.com, matthew@....cx, will.newton@...il.com,
	drepper@...hat.com, microblaze-uclinux@...e.uq.edu.au,
	grant.likely@...retlab.ca, Michal Simek <monstr@...str.eu>
Subject: Re: [PATCH 50/56] microblaze_v2: setup.h string.h thread_info.h


> +++ b/include/asm-microblaze/thread_info.h
> @@ -0,0 +1,155 @@
> +/*
> + * include/asm-microblaze/thread_info.h
> + *
> + * This file is subject to the terms and conditions of the GNU General Public
> + * License. See the file "COPYING" in the main directory of this archive
> + * for more details.
> + *
> + * Copyright (C) 2006 Atmark Techno, Inc.
> + */
> +
> +#ifndef _ASM_MICROBLAZE_THREAD_INFO_H
> +#define _ASM_MICROBLAZE_THREAD_INFO_H
> +
> +#ifdef __KERNEL__
> +
> +/* we have 8k stack */

Is it worth trialling a 4K stack on MicroBlaze?


> +struct cpu_context {
> +	__u32	sp;

I'd be happier to see this called r1.  If mb-as doesn't accept "sp" as
an alias for "r1", nor should we.

...

> +	__u32	r30;

Is it worth a comment that r31 is absent because it's used as 'current'
pointer, and -ffixed-r31 etc?



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/