linux-kernel - Re: x86: Clean up computation of HPET .mult variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 6 May 2008 10:13:08 -0300
From:	"Carlos R. Mafra" <crmafra2@...il.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	linux-kernel@...r.kernel.org, tglx@...utronix.de,
	venkatesh.pallipadi@...el.com
Subject: Re: x86: Clean up computation of HPET .mult variables


> since you seem to be interested in HPET topics, what do you think about 
> the patch below from akpm? It had a build failure with this config:
> 
>   http://redhat.com/~mingo/misc/config-Sun_May__4_09_41_21_CEST_2008.bad
> 
> but the general cleanliness point Andrew raises is valid i think.

Heh, thanks! I will try hard to understand what is going on with
Andrew's patch and get back to you later if I succeed.


> 	Ingo
> 
> ------------->
> From: Andrew Morton <akpm@...ux-foundation.org>
> 
> Should already be available via the hpet.h inclusion.
> 
> Could go further, by defining the do-nothing stub in hpet.h as well, perhaps.
> 
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Ingo Molnar <mingo@...e.hu>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> ---
> 
>  drivers/char/rtc.c     |    2 --
>  drivers/rtc/rtc-cmos.c |    1 -
>  2 files changed, 3 deletions(-)
> 
> diff -puN drivers/char/rtc.c~rtc-remove-unneeded-declarations-of-hpet_rtc_interrupt drivers/char/rtc.c
> --- a/drivers/char/rtc.c~rtc-remove-unneeded-declarations-of-hpet_rtc_interrupt
> +++ a/drivers/char/rtc.c
> @@ -119,8 +119,6 @@ static irqreturn_t hpet_rtc_interrupt(in
>  	return 0;
>  }
>  #endif
> -#else
> -extern irqreturn_t hpet_rtc_interrupt(int irq, void *dev_id);
>  #endif
>  
>  /*
> diff -puN drivers/rtc/rtc-cmos.c~rtc-remove-unneeded-declarations-of-hpet_rtc_interrupt drivers/rtc/rtc-cmos.c
> --- a/drivers/rtc/rtc-cmos.c~rtc-remove-unneeded-declarations-of-hpet_rtc_interrupt
> +++ a/drivers/rtc/rtc-cmos.c
> @@ -52,7 +52,6 @@
>  #define hpet_rtc_timer_init() 			do { } while (0)
>  #define hpet_register_irq_handler(h) 		0
>  #define hpet_unregister_irq_handler(h)		do { } while (0)
> -extern irqreturn_t hpet_rtc_interrupt(int irq, void *dev_id);
>  #endif
>  
>  struct cmos_rtc {
> _

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/