linux-kernel - RE: [PATCH 24/56] microblaze

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 6 May 2008 09:36:34 -0700
From:	"Stephen Neuendorffer" <stephen.neuendorffer@...inx.com>
To:	"Arnd Bergmann" <arnd@...db.de>, <monstr@...nam.cz>
Cc:	"John Williams" <john.williams@...alogix.com>,
	<linux-kernel@...r.kernel.org>, <linux-arch@...r.kernel.org>,
	"John Linn" <linnj@...inx.com>, <matthew@....cx>,
	<will.newton@...il.com>, <drepper@...hat.com>,
	<microblaze-uclinux@...e.uq.edu.au>, <grant.likely@...retlab.ca>
Subject: RE: [PATCH 24/56] microblaze_v2: time support

> I think you're doing a great job on this. Any patch set of this size
that
> has been maintained for a long time outside of the kernel goes through
this
> phase where everyone tells you what to improve, based on their
experience,
> while everything you do right about the patches is just taken for
granted.

I completely agree on this.  I think you're making a huge amount of
progress and spending alot of time incorporating alot of comments from
alot of people.

My main priority is to get as many of the improvements that we've had at
in our git tree, so as to be able to switch to the mainline code as
quickly as possible.  If I keep bringing up the same things it is
because they are barriers to that happening.  I very much want to put a
big ACK on everything, but I'm uncomfortable doing that until I can at
least boot it, and that hasn't happened yet.

> Don't let yourself get discouraged by the negative comments, we're
really
> all just trying to help you do the right thing!

One of the key things that many people take a long time to learn is that
negative comments about code are not a reflection of negativity towards
the person who wrote the code.

Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/