linux-kernel - Re: [PATCH] clocksource: shift helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 06 May 2008 14:01:15 -0700
From:	Daniel Walker <dwalker@...sta.com>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	akpm@...ux-foundation.org, johnstul@...ibm.com,
	ralf@...ux-mips.org, anemo@....ocn.ne.jp,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clocksource: shift helper


On Tue, 2008-05-06 at 22:53 +0200, Thomas Gleixner wrote:
> 
> And your description led me to the assumption that the code was pulled
> from the MIPS git tree and not from the MIPS architecture code in
> mainline. Everyone else I talked to was having the same impression.
> 
> I was wrong, but can you understand that your sloppy wording "pulled
> from the MIPS tree" along with the fact that you just copied code
> instead of moving it into the generic space and cleanup the MIPS code
> where it is duplicated from is causing such a misunderstanding ?

You could have asked me if it was mainline or not. I can see how words
could be misunderstood .

> I'm fine with the change itself, but it needs to move the code out of
> MIPS in the first place and not just duplicating code for no good
> reason.

I can work with Atsushi, but I still think the generic version should be
merged. We at least would need it in order to modify the mips code.

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/