linux-kernel - Re: [PATCH 3/3] PNP: add AD1815 and AD1816 quirks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 6 May 2008 15:27:20 -0600
From:	Bjorn Helgaas <bjorn.helgaas@...com>
To:	Rene Herman <rene.herman@...access.nl>
Cc:	Uwe Bugla <uwe.bugla@....de>, Takashi Iwai <tiwai@...e.de>,
	Len Brown <len.brown@...el.com>, Andrew Morton <akpm@...l.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] PNP: add AD1815 and AD1816 quirks

On Tuesday 06 May 2008 03:06:14 pm Rene Herman wrote:
> ...
> > I'm vaguely uncomfortable because this quirk isn't really working
> > around a hardware/firmware issue; it's stepping around the fact
> > that Linux doesn't know how to allocate IRQs between ISA and PCI.
> > Does anybody know how Windows handles this?  If Windows can do it
> > without user intervention, maybe we can too.
> 
> Yes, I can appreciate the vague uncomfort. This is improving the hardware 
> more then it is fixing it and that might feel like a bit of a misuse of 
> quirks. However, given Linux's ability to operate the MPU401 fully without 
> an assigned IRQ I feel it does make sense. The hardware shouldn't become 
> unavailable just because the system can't find a free IRQ for it.

OK, thanks a lot for the explanation.  It makes a lot more sense
now, and I'm happy with your approach now.  It shouldn't make anything
worse, and it should make the card useful in some cases where it
wasn't before.

> However, with respect to your direct worry I get sort of foggy. All my ISA 
> capable systems seem to have a BIOS that assigns IRQs to each PCI card that 
> I put in as evidenced by the neat list of them that most of them print out 
> just before the screen says "Verifying DMI Pool Data" and loading linux, an 
> OS which I don't recall having ever seen deviate from the BIOS assigned 
> values either.
> 
> That is, I'm not sure in how far Linux is involved at all :-?

This part is just my general unhappiness about options like
"acpi_irq_nobalance" and "acpi_irq_isa=".  I was just wondering
what Windows does when it can't assign PNP IRQs.  Does it assign
them all before PCI, so they know they have enough?  Do it
dynamically move PCI interrupts?  Do it require explicit boot
flags like Linux does?  Or maybe nobody even needs those flags
on Linux, and the flags are effectively unused.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/