linux-kernel - Re: [PATCH 08/18] flag parameters: epoll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 7 May 2008 01:10:53 +0200
From:	"Michael Kerrisk" <mtk.manpages@...glemail.com>
To:	"Davide Libenzi" <davidel@...ilserver.org>
Cc:	"Matthew Helsley" <matthltc@...ibm.com>,
	"Ulrich Drepper" <drepper@...hat.com>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
	netdev@...r.kernel.org,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	mtk.manpages@...il.com,
	"Linus Torvalds" <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 08/18] flag parameters: epoll_create

On Wed, May 7, 2008 at 12:41 AM, Davide Libenzi <davidel@...ilserver.org> wrote:
>
> On Tue, 6 May 2008, Matthew Helsley wrote:
>
> >
> > On Sun, 2008-05-04 at 23:42 -0400, Ulrich Drepper wrote:
> > > This patch adds the new epoll_create2 syscall.  It extends the old epoll_create
> > > syscall by one parameter which is meant to hold a flag value.  In this
> > > patch the only flag support is EPOLL_CLOEXEC which causes the close-on-exec
> > > flag for the returned file descriptor to be set.
> >
> > Davide, Ulrich,
> >
> >       A minor question: Why did you choose to pass the seemingly useless
> > "size" parameter into the new epoll_create2 system call? I did some
> > googling for previous threads with this series and couldn't find a
> > discussion on why you chose to keep it.
>
> The very first implementations were using an hash, and that was a size
> hint.

So, why not simply remove this argument in the new API, since it is now useless?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/