linux-kernel - Re: [Linux-fbdev-devel] [PATCH 7/9] viafb: VIA Frame Buffer Device Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 7 May 2008 18:50:14 +0200
From:	Krzysztof Helt <krzysztof.h1@...zta.fm>
To:	<JosephChan@....com.tw>
Cc:	<akpm@...ux-foundation.org>, <geert@...ux-m68k.org>,
	linux-fbdev-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: [Linux-fbdev-devel] [PATCH 7/9] viafb: VIA Frame Buffer Device
 Driver

On Wed, 7 May 2008 19:09:44 +0800
<JosephChan@....com.tw> wrote:

> Signed-off-by: Joseph Chan <josephchan@....com.tw>
> 
> diff -Nur a/drivers/video/via/viafbdev.h b/drivers/video/via/viafbdev.h
> --- a/drivers/video/via/viafbdev.h	1969-12-31 19:00:00.000000000 -0500
> +++ b/drivers/video/via/viafbdev.h	2008-04-29 04:27:46.000000000 -0400
> @@ -0,0 +1,114 @@

(...)
> +
> +struct viafb_par {
> +	struct fb_var_screeninfo var;
> +	int bpp;
> +	int hres;
> +	int vres;
> +	int linelength;
> +	int vclk;		/*in MHz */
> +
> +	int vtotal;
> +	int vdispend;
> +	int vsyncstart;
> +	int vsyncend;
> +	int vblankstart;
> +	int vblankend;
> +
> +	int htotal;
> +	int hdispend;
> +	int hsyncstart;
> +	int hsyncend;
> +	int hblankstart;
> +	int hblankend;
> +
> +	int accel;		/* Acceleration Flags */

A random pick of "accel", "hblankstart" and "hblankend" shows that they are only set and never checked. Try to remove all unused fields here.

Regards,
Krzysztof

----------------------------------------------------------------------
Lepszy niz zakladki. 	
Kliknij >>> http://link.interia.pl/f1db1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/