linux-kernel - Re: 2.6.26, PAT and AMD family 6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 8 May 2008 00:08:23 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Adrian Bunk <bunk@...nel.org>
cc:	Rene Herman <rene.herman@...access.nl>,
	Yinghai Lu <yhlu.kernel@...il.com>,
	Ingo Molnar <mingo@...e.hu>,
	Linux Kernel <linux-kernel@...r.kernel.org>, hpa@...or.com,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	Pavel Machek <pavel@...e.cz>
Subject: Re: 2.6.26, PAT and AMD family 6

On Thu, 8 May 2008, Adrian Bunk wrote:
> > 
> > Yinghai missed to add it to the other place and he is hardly to blame
> > for that. This code is messy and thats not his fault. It will be
> > cleaned up, but that's not an simple taks to do. If you think you can
> > do it without breaking tons of systems, you're welcome.
> 
> It actually is completely his fault.

No it is not. 

1) this code is messy to begin with

2) we accepted the change as is
 
> His commit ***added*** the three copies of the same code.

And you are not able to ******look******* over the brim of your tea
cup and accept that one of them is 64 bit and the others are a tribute
to the not yet distangled shit. There would have been a cleaner and
better way to solve this, but there is always a better and cleaner way
to do things.

Why dont you send a cleanup patch which fixes the three copies problem
instead of spending your time with writing up ivory tower pieces of
wisdom ?

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/