linux-kernel - Re: 2.6.26, PAT and AMD family 6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 8 May 2008 00:29:37 +0200
From:	Pavel Machek <pavel@...e.cz>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	Adrian Bunk <bunk@...nel.org>,
	Rene Herman <rene.herman@...access.nl>,
	Yinghai Lu <yhlu.kernel@...il.com>,
	Ingo Molnar <mingo@...e.hu>,
	Linux Kernel <linux-kernel@...r.kernel.org>, hpa@...or.com,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org
Subject: Re: 2.6.26, PAT and AMD family 6


> > His commit ***added*** the three copies of the same code.
> 
> And you are not able to ******look******* over the brim of your tea
> cup and accept that one of them is 64 bit and the others are a tribute
> to the not yet distangled shit. There would have been a cleaner and
> better way to solve this, but there is always a better and cleaner way
> to do things.

Existing code being a mess is not an excuse for messing it up a bit
more. Which is exactly what Yinghai did.

> Why dont you send a cleanup patch which fixes the three copies problem
> instead of spending your time with writing up ivory tower pieces of
> wisdom ?

Because no ammount of cleanup patches will solve "Ingo did not even
notice missing changelog, and 2 NAKs"?

commit 9307cacad0dfe3749f00303125c6f7f0523e5616 
tree bc28bf08dc18dacbb2654a9a368f4e09c580dfab 
parent a7c7d0e91daebd7c5e51f9416d612b6a15e7e79a 
author Yinghai Lu <yhlu.kernel.send@...il.com> Mon, 24 Mar 2008 23:24:34 -0700 
committer Ingo Molnar <mingo@...e.hu> Thu, 17 Apr 2008 17:41:20 +0200 

    x86: pat cpu feature bit setting for known cpus
    
    Signed-off-by: Yinghai Lu <yhlu.kernel@...il.com>
    Signed-off-by: Ingo Molnar <mingo@...e.hu>

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/