linux-kernel - Re: [resend] [PATCH v2] ibmaem: New driver for power/energy meters in IBM System X hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 6 May 2008 17:36:07 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	djwong@...ibm.com
Cc:	linux-kernel@...r.kernel.org, lm-sensors@...sensors.org,
	mhoffman@...htlink.com
Subject: Re: [resend] [PATCH v2] ibmaem: New driver for power/energy meters
 in IBM System X hardware

On Tue, 6 May 2008 15:38:13 -0700 "Darrick J. Wong" <djwong@...ibm.com> wrote:

> [resend due to truncation]
> Refactor the registration function to shrink the macros.  Let me know if
> more aggressive de-macroing is desirable.
> ---
> New driver for power meters in IBM System X hardware, with a few
> cleanups suggested by Anthony Liguori.
> 
> ...
>
> +	int temp = simple_strtol(buf, NULL, 10); \

A checkpatch version which you might not have says

WARNING: consider using strict_strtol in preference to simple_strtol
#1015: FILE: drivers/hwmon/ibmaem.c:918:
+       int temp = simple_strtol(buf, NULL, 10); \

total: 0 errors, 1 warnings, 1221 lines checked

because the code as you have it will accept input of the form "12foo". 
strict_strtol() will error on that.

afacit the calling code would perhaps need a little changing to handle
such errors appropriately.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/