linux-kernel - Re: [PATCH] x86: introduce a new Linux defined feature flag for PAT support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 07 May 2008 19:11:23 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
CC:	Rene Herman <rene.herman@...access.nl>,
	Thomas Gleixner <tglx@...utronix.de>,
	Adrian Bunk <bunk@...nel.org>,
	Yinghai Lu <yhlu.kernel@...il.com>,
	Ingo Molnar <mingo@...e.hu>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	akpm@...ux-foundation.org, Pavel Machek <pavel@...e.cz>
Subject: Re: [PATCH] x86: introduce a new Linux defined feature flag for PAT
 support

Linus Torvalds wrote:
> 
> On Thu, 8 May 2008, Rene Herman wrote:
>> Okay, so how's this? Seem to work well for me and makes me happy. Only
>> tested on UP.
> 
> Looks sane to me.
> 
> Not that I ever really saw the point about this whole argument in the 
> first place. Clearing the flags wasn't really wrong to begin with.
> 

Indeed it wasn't, and at least I have no interest of maintaining what is 
in effect an in-kernel version of x86info(1).

*Certainly* I don't want anything like this crap:

> diff --git a/arch/x86/mm/pat.c b/arch/x86/mm/pat.c
> index 277446c..6ee3efb 100644
> --- a/arch/x86/mm/pat.c
> +++ b/arch/x86/mm/pat.c
> @@ -43,7 +43,7 @@ static int pat_known_cpu(void)
>     if (!pat_wc_enabled)
>         return 0;
> 
> -    if (cpu_has_pat)
> +    if (cpu_has_pat && cpu_has_pat_good)
>         return 1;
> 
>     pat_wc_enabled = 0; 

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/