linux-kernel - Re: [PATCH 0/3] ia64: Migrate data off physical pages with correctable errors v3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 9 May 2008 08:21:32 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Russ Anderson <rja@....com>
cc:	linux-kernel@...r.kernel.org, linux-ia64@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Tony Luck <tony.luck@...el.com>,
	Christoph Lameter <clameter@....com>
Subject: Re: [PATCH 0/3] ia64: Migrate data off physical pages with correctable
 errors v3

On Fri, 9 May 2008, Russ Anderson wrote:
> 
>   [2/3] page.discard.v2: Avoid putting a bad page back on the LRU.
> 
> 	page.discard are the arch independent changes.  It adds a new
> 	page flag (PG_memerror) to mark the page as bad and prevent it
> 	from being put back on the LRU.  PG_memerror is only defined
> 	on 64 bit architectures. 

So I haven't looked at this a lot, but it strikes me that it look to be 
much simple if you were to just increment the page count instead of 
playing games in mm/page_alloc.c.

That will make sure that it never goes back on any free lists, and 
requires no changes to the allocator. Hmm?

I'm also not really seeing why this triggers on lru_cache_add(), since 
that should only happen to new pages anyway. Who does lru_cache_add() on 
old pages?

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/