linux-kernel - [2.6.24] [Q] x86: clear DF before calling signal handler II.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sat, 10 May 2008 22:33:09 +0200
From:	"Oliver Pinter" <oliver.pntr@...il.com>
To:	linux-kernel@...r.kernel.org, "H. Peter Anvin" <hpa@...or.com>,
	"Ingo Molnar" <mingo@...e.hu>,
	"Aurelien Jarno" <aurelien@...el32.net>
Subject: [2.6.24] [Q] x86: clear DF before calling signal handler II.

Hi LKML!

Im mainline e40cd10ccff3d9fbffd57b93780bee4b7b9bff51 commit
( x86: clear DF before calling signal handler ) changed the ~TF_MASK and
~X86_EFLAGS_TF to ~(~X86_EFLAGS_TF | ~X86_EFLAGS_DF).

 include/asm-x86/signal.h:
-------------------------->
 248 #define ptrace_signal_deliver(regs, cookie)             \
 249         do {                                            \
 250                 if (current->ptrace & PT_DTRACE) {      \
 251                         current->ptrace &= ~PT_DTRACE;  \
 252                         (regs)->eflags &= ~TF_MASK;     \ <-----------
 253                 }                                       \
 254         } while (0)
<-------------------------

Signed-off-by: Oliver Pinter <oliver.pntr@...il.com>

the question:
in this file the change is unnecessary or forgotted?

NO COMPILE TESTED!

---

diff --git a/include/asm-x86/signal.h b/include/asm-x86/signal.h
index 987a422..71effa1 100644
--- a/include/asm-x86/signal.h
+++ b/include/asm-x86/signal.h
@@ -249,7 +249,7 @@ struct pt_regs;
        do {                                            \
                if (current->ptrace & PT_DTRACE) {      \
                        current->ptrace &= ~PT_DTRACE;  \
-                       (regs)->eflags &= ~TF_MASK;     \
+                       (regs)->eflags &= ~(TF_MASK | X86_EFLAGS_DF);   \
                }                                       \
        } while (0)



-- 
Thanks,
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/