linux-kernel - Re: build issue #380 for v2.6.26-rc1-279-g28a4acb : mach-voyager: multiple definition of `phys_cpu_present

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 10 May 2008 09:21:24 -0500
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	WANG Cong <xiyou.wangcong@...il.com>, toralf.foerster@....de,
	linux-kernel@...r.kernel.org, "H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Mike Travis <travis@....com>,
	Alexey Starikovskiy <astarikovskiy@...e.de>
Subject: Re: build issue #380 for v2.6.26-rc1-279-g28a4acb : mach-voyager:
	multiple definition of `phys_cpu_present_map'

On Sat, 2008-05-10 at 09:01 -0500, James Bottomley wrote:
> On Sat, 2008-05-10 at 15:17 +0200, Ingo Molnar wrote:
> > * Ingo Molnar <mingo@...e.hu> wrote:
> > 
> > > > I already told you that this was incorrect.  This is what I sent as 
> > > > the replacement on 28 April and I didn't hear back from you.
> > > > 
> > > > http://marc.info/?l=linux-kernel&m=120941111400620
> > > 
> > > ok - picked it up for testing - could you please send a signoff line 
> > > as well?
> > 
> > Alexey, the patch from James failed in testing on visws:
> > 
> >  arch/x86/kernel/built-in.o: In function `init_apic_mappings':
> >  : undefined reference to `boot_cpu_physical_apicid'
> >  arch/x86/kernel/built-in.o: In function `init_apic_mappings':
> >  : undefined reference to `boot_cpu_physical_apicid'
> >  arch/x86/kernel/built-in.o: In function `APIC_init_uniprocessor':
> >  : undefined reference to `boot_cpu_physical_apicid'
> >  arch/x86/kernel/built-in.o: In function `APIC_init_uniprocessor':
> > 
> > config is at:
> > 
> >   http://redhat.com/~mingo/misc/config-Sat_May_10_15_05_47_CEST_2008.bad
> 
> OK, so these symbols are required on visws as well.  So that makes the
> gating config symbol X86_LOCAL_APIC.
> 
> Could you run this through the same config to verify; thanks!

By the way, if this patch survives all the randconfig testing, it shows
the symbols don't belong in setup.c; they should be in apic.c (the
beginnings of the unified apic files).  I'll redo the patch that way on
testing confirmation.

Thanks,

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/