linux-kernel - Re: [Patch 3/9] fs/compat.c: fix resource leaks and wrong goto's

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 May 2008 05:05:54 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	WANG Cong <xiyou.wangcong@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, Andrew Morton <akpm@...l.org>,
	WANG Cong <wangcong@...ux.org>
Subject: Re: [Patch 3/9] fs/compat.c: fix resource leaks and wrong goto's

On Mon, May 12, 2008 at 11:46:09AM +0800, WANG Cong wrote:
> >@@ -1320,17 +1326,15 @@ int do_execve(char * filename,
> > 	retval = search_binary_handler(bprm,regs);
> > 	if (retval >= 0) {
> > 		/* execve success */
> >-		free_arg_pages(bprm);
> > 		security_bprm_free(bprm);
> > 		acct_update_integrals(current);
> >-		kfree(bprm);
> >+		free_bprm(bprm);
> > 		if (displaced)
> > 			put_files_struct(displaced);
> > 		return retval;
> > 	}
> > 
> > out:
> >-	free_arg_pages(bprm);
> 
> 
> Why just drop this? No need to call free_bprm()?

Fixed, pushed to vfs-2.6.git...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/