linux-kernel - Re: [PATCH 1/1 try#2] [INPUT] keypad driver: Added support for OpenCores Keyboard Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 12 May 2008 13:50:42 +0800
From:	"Bryan Wu" <cooloney@...nel.org>
To:	"Javier Herrero" <jherrero@...istemas.es>
Cc:	"Vojtech Pavlik" <vojtech@...e.cz>,
	"Bryan Wu" <bryan.wu@...log.com>,
	"Will Newton" <will.newton@...il.com>, dmitry.torokhov@...il.com,
	linux-input@...ey.karlin.mff.cuni.cz, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1 try#2] [INPUT] keypad driver: Added support for OpenCores Keyboard Controller

On Tue, Feb 5, 2008 at 7:33 PM, Javier Herrero <jherrero@...istemas.es> wrote:
> Vojtech Pavlik escribió:
>>
>> On Tue, Feb 05, 2008 at 12:18:15PM +0100, Javier Herrero wrote:
>>>
>>> Dear Vojtech,
>>>
>>> I think that a 1:1 mapping between linux keycodes and what keyboard sends
>>> is right, because the scan code to key code conversion is already programmed
>>> and done inside the FPGA code.
>>
>> And the FPGA code changes with different keyboards attached?
>>
> The original OpenCores keyboard controller is a 6 rows x 12 cols keyboard
> controller that can be customized for other row/col sizes modifiying
> Constants.vhd VHDL file, in which also the translation table is defined, and
> for different key disposition schemes both the number of rows and cols can
> be changed. We are currently using this controller with a 4x4 key matrix,
> and with a different key mapping values, so I thought that it would be
> preferable to have the driver mapping fixed to 1:1 and do the mapping in the
> VHDL, since in most cases the keyboard using this controller would be
> different to the default keyboard defined in the original Contants.vhd VHDL
> file.
>
> Regards,
>
> Javier
>

Hi Vojtech, Will and Dmitry,

How do you think of this driver from Javier?
It works fine on Blackfin arch, but it can also be shared by other platform.
So this driver is useful of the other developers.
Could you please consider merging this driver?

If you need me to resend this patch, please ping me.

Thanks
-Bryan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/