lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <386072610805130136n52366cc3u666b93164884fa42@mail.gmail.com>
Date:	Tue, 13 May 2008 16:36:51 +0800
From:	"Bryan Wu" <cooloney@...nel.org>
To:	"Hennerich, Michael" <Michael.Hennerich@...log.com>
Cc:	"Marcel Holtmann" <marcel@...tmann.org>,
	linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] [bluetooth]: fix bug - kernel warning detected ifbuilt in Bluetooth CF driver

On Tue, May 13, 2008 at 4:20 PM, Hennerich, Michael
<Michael.Hennerich@...log.com> wrote:
>
>
>
>  >-----Original Message-----
>  >From: Marcel Holtmann [mailto:marcel@...tmann.org]
>  >Sent: Montag, 12. Mai 2008 15:10
>  >To: Bryan Wu
>  >Cc: linux-bluetooth@...r.kernel.org; linux-kernel@...r.kernel.org;
>  Michael
>  >Hennerich
>  >Subject: Re: [PATCH 1/1] [bluetooth]: fix bug - kernel warning detected
>  >ifbuilt in Bluetooth CF driver
>  >
>  >Hi Brian,
>  >
>  >> https://blackfin.uclinux.org/gf/project/uclinux-
>  >dist/tracker/?action=TrackerItemEdit&tracker_item_id=2650
>  >>
>  >> Signed-off-by: Michael Hennerich <michael.hennerich@...log.com>
>  >> Signed-off-by: Bryan Wu <cooloney@...nel.org>
>  >> ---
>  >>  drivers/bluetooth/bluecard_cs.c |    2 +-
>  >>  1 files changed, 1 insertions(+), 1 deletions(-)
>  >>
>  >> diff --git a/drivers/bluetooth/bluecard_cs.c
>  >b/drivers/bluetooth/bluecard_cs.c
>  >> index bcf5792..3b330a0 100644
>  >> --- a/drivers/bluetooth/bluecard_cs.c
>  >> +++ b/drivers/bluetooth/bluecard_cs.c
>  >> @@ -867,7 +867,7 @@ static int bluecard_probe(struct pcmcia_device
>  *link)
>  >>
>  >>      link->io.Attributes1 = IO_DATA_PATH_WIDTH_8;
>  >>      link->io.NumPorts1 = 8;
>  >> -    link->irq.Attributes = IRQ_TYPE_EXCLUSIVE | IRQ_HANDLE_PRESENT;
>  >> +    link->irq.Attributes = IRQ_TYPE_DYNAMIC_SHARING |
>  IRQ_HANDLE_PRESENT;
>  >>      link->irq.IRQInfo1 = IRQ_LEVEL_ID;
>  >>
>  >>      link->irq.Handler = bluecard_interrupt;
>  >
>  >all Bluetooth PCMCIA drivers use an exclusive IRQ:
>  >
>  >bluecard_cs.c: link->irq.Attributes = IRQ_TYPE_EXCLUSIVE |
>  >IRQ_HANDLE_PRESENT;
>  >bt3c_cs.c:     link->irq.Attributes = IRQ_TYPE_EXCLUSIVE |
>  IRQ_HANDLE_PRESENT;
>  >btuart_cs.c:   link->irq.Attributes = IRQ_TYPE_EXCLUSIVE |
>  >IRQ_HANDLE_PRESENT;
>  >dtl1_cs.c:     link->irq.Attributes = IRQ_TYPE_EXCLUSIVE |
>  IRQ_HANDLE_PRESENT;
>  >
>  >There was a reason for that when these drivers where written. I am not
>  >sure if it is still valid or not. Does anybody at least have tested
>  that
>  >the cards still work if you use a shared IRQ.
>  >
>  >Regards
>  >
>  >Marcel
>
>  Please disregard this patch. It's a leftover and not really necessary.
>  Some time ago the Blackfin PCMCIA driver also requested the Card IRQ in
>  order to shut up some irq handling noise. However this is no longer the
>  case.
>

OK, no problem. I will drop this.

Thanks
-Bryan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ