linux-kernel - Re: [PATCH] kallsyms: fix potential overflow in binary search

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 14 May 2008 15:22:00 +0300
From:	"Pekka Enberg" <penberg@...helsinki.fi>
To:	"Paulo Marques" <pmarques@...popie.com>
Cc:	"Vegard Nossum" <vegard.nossum@...il.com>,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kallsyms: fix potential overflow in binary search

On Wed, May 14, 2008 at 2:44 PM, Paulo Marques <pmarques@...popie.com> wrote:
> > This will probably never trigger... but it won't hurt to be careful.
>
>  Not "probably", this will never trigger _period_. If you ever have more
> than 2^31 symbols in the kernel's kallsyms table you'll have worse problems
> to worry about than the binary search overflowing.
>
>  So, I don't think it is worth this des-optimization at all...

Yes it is. It serves as correct reference code and the
"deoptimization" is not measurable.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/