linux-kernel - Re: BUG: Ecryptfs ioctl handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 22 May 2008 13:53:44 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	mahalcro@...ibm.com, linux-kernel@...r.kernel.org
Subject: Re: BUG: Ecryptfs ioctl handling

On Thursday 22 May 2008, Alan Cox wrote:
> 
> Ecryptfs has an ioctl method that checks for the underlying fs ioctl
> method and can call down into. Unfortunately however it doesn't check for
> an underlying unlocked_ioctl method and call that if present.
> 
> Notices while removing the remaining users of ->ioctl from my dev tree.
> 
> Really ecryptfs needs its own ->unlocked_ioctl op to call into either
> unlocked ioctl below or lock_kernel/ioctl/unlock_kernel below.

Similarly, ecryptfs doesn't provide a ->compat_ioctl op that calls into
the file system's ->compat_ioctl operation if present.
This will be needed to make ioctl handling work on file systems that
rely on ->compat_ioctl for 32 bit processes.

I wonder if there are other places in the kernel that just pass down
ioctl calls to a slave file system or driver and need to have this
added.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/