linux-kernel - Re: Latest Linus git: kernel/sched.c:1216: warning: ?init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 26 May 2008 20:04:37 -0300
From:	Kevin Winchester <kjwinchester@...il.com>
To:	Ingo Molnar <mingo@...e.hu>
CC:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: Latest Linus git: kernel/sched.c:1216: warning: ?init_hrtick?
 defined but not used

Ingo Molnar wrote:
> * Kevin Winchester <kjwinchester@...il.com> wrote:
> 
>> Hi Ingo,
>>
>> I got the above warning in my latest build.  I assume it is because 
>> init_hrtick() is only called from CONFIG_SMP sched_init_smp(), and I 
>> have a HRT-enabled UP box.
>>
>> I could write up the simple patch to put #ifdef CONFIG_SMP around 
>> init_hrtick(), but with all of the #ifdefs in that file, I figure it 
>> is probably a little more complicated than that.
> 
> the fix seems simple - see below. The #ifdef jungle ... less so.
> 
> 	Ingo
> 
> --------------->
> Subject: sched: fix defined-but-unused warning
> From: Rabin Vincent <rabin@....in>
> Date: Sun, 11 May 2008 05:55:33 +0530
> 
> Fix this warning, which appears with !CONFIG_SMP:
> kernel/sched.c:1216: warning: `init_hrtick' defined but not used
> 
> Signed-off-by: Rabin Vincent <rabin@....in>
> Signed-off-by: Ingo Molnar <mingo@...e.hu>
> ---
>  kernel/sched.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> Index: linux/kernel/sched.c
> ===================================================================
> --- linux.orig/kernel/sched.c
> +++ linux/kernel/sched.c
> @@ -1130,6 +1130,7 @@ static enum hrtimer_restart hrtick(struc
>  	return HRTIMER_NORESTART;
>  }
>  
> +#ifdef CONFIG_SMP
>  static void hotplug_hrtick_disable(int cpu)
>  {
>  	struct rq *rq = cpu_rq(cpu);
> @@ -1185,6 +1186,7 @@ static void init_hrtick(void)
>  {
>  	hotcpu_notifier(hotplug_hrtick, 0);
>  }
> +#endif /* CONFIG_SMP */
>  
>  static void init_rq_hrtick(struct rq *rq)
>  {

Did this ever make it to a pull request?  I still see the warning with 
latest git.

-- 
Kevin Winchester
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/