linux-kernel - Re: Input+S3: extra keycodes forgotten after suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 27 May 2008 22:52:55 +0200
From:	Bruno Prémont <bonbons@...ux-vserver.org>
To:	Dmitry Torokhov <dtor@...ightbb.com>
Cc:	Linux Input <linux-input@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"R. J. Wysocki" <Rafal.Wysocki@....edu.pl>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>
Subject: Re: Input+S3: extra keycodes forgotten after suspend

On Tue, 27 May 2008 Dmitry Torokhov <dtor@...ightbb.com> wrote:
> On Friday 23 May 2008 16:57, Bruno Prémont wrote:
> > On Fri, 23 May 2008 Dmitry Torokhov <dmitry.torokhov@...il.com> wrote:
> > > > Ah, ok, great.. I think we simply need to move dritek out of the
> > > > place where you put it in so it does not interfere with our
> > > > efforts to resume keyboard and mouse ;) I will see what I can
> > > > do there..
> > > > 
> > > 
> > > So what about the patch below? Does it work for you?
> > > 
> > > Thanks!
> > 
> > Hi Dmitry,
> > 
> > Yes, this patch works for me (in combination with
> > http://lkml.org/lkml/2008/5/16/430 ), see attached
> > boot+suspend&resume log.
> > 
> > You will eventually note the following lines during resume process:
> > ...
> > [  150.588965] /usr/src/linux-2.6.25.4-orig/drivers/input/serio/i8042.c: 60 -> i8042 (command) [15985]
> > [  150.588965] /usr/src/linux-2.6.25.4-orig/drivers/input/serio/i8042.c: 47 -> i8042 (parameter) [15985]
> > [  150.588965] /usr/src/linux-2.6.25.4-orig/drivers/input/serio/i8042.c: 00 <- i8042 (interrupt, 0, 0) [15985]
> > [  150.588965] atkbd.c: Unknown key pressed (translated set 2, code 0x0 on isa0060/serio0).
> > [  150.588965] atkbd.c: Use 'setkeycodes 00 <keycode>' to make it known.
> > [  150.588965] /usr/src/linux-2.6.25.4-orig/drivers/input/serio/i8042.c: f2 -> i8042 (kbd-data) [15985]
> > [  150.609410] /usr/src/linux-2.6.25.4-orig/drivers/input/serio/i8042.c: fa <- i8042 (interrupt, 0, 1) [15987]
> > ...
> > 
> 
> I see. Could you please try the patch below (in addition to the other
> 2 you have) and see if that 00 keycode is still reported?
> 
> Thanks! 
> 
Yes, the 00 keycode is gone with this patch on top of the two I have,
the dritek keys still works as expected after resume.
Attached is the dmesg output (two suspends, only second one with i8042
debug output enabled)

Thanks for the patches,
Bruno

View attachment "input-suspend-debug12.log" of type "text/plain" (96132 bytes)