linux-kernel - Re: [PATCH] video4linux: Push down the BKL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 27 May 2008 20:46:22 -0400
From:	"Devin Heitmueller" <devin.heitmueller@...il.com>
To:	"Andy Walls" <awalls@...ix.net>
Cc:	"Mauro Carvalho Chehab" <mchehab@...radead.org>,
	"Alan Cox" <alan@...hat.com>, video4linux-list@...hat.com,
	linux-kernel@...r.kernel.org,
	"Alan Cox" <alan@...rguk.ukuu.org.uk>,
	"Jonathan Corbet" <corbet@....net>
Subject: Re: [PATCH] video4linux: Push down the BKL

Hello Andy,

On Tue, May 27, 2008 at 7:48 PM, Andy Walls <awalls@...ix.net> wrote:
> MythTV's mythbackend can open both sides of the card at the same time
> and the cx18 driver supports it.  On my HVR-1600, MythTV may have the
> digital side of the card open pulling EPG data off of the ATSC
> broadcasts, when I open up the MythTV frontend and start watching live
> TV on the analog side of the card.  MythTV also supports
> Picture-in-Picture using both the analog and digital parts of the
> HVR-1600.

In this case, what you see as a 'feature' in MythTV is actually a
problem in our case.  While the HVR-1600 can support this scenario,
the HVR-950 can only use one or the other (the em28xx chip uses GPIOs
to enable the demodulator and presumably you should never have both
demodulators enabled at the same time).  Because of this we need a
lock.  If MythTV only opened one device or the other at a time, we
could put the lock on the open() call, but since MythTV opens both
simultaneously even though it may only be using one, we would need a
much more granular lock.

Certainly I'm not blaming MythTV for this behavior, but it will make
the locking much more complicated in some hybrid devices.

-- 
Devin J. Heitmueller
http://www.devinheitmueller.com
AIM: devinheitmueller
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/