linux-kernel - Re: HAVE_CLK (for <linux/clk.h> support)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 28 May 2008 03:05:47 +0300
From:	"Felipe Balbi" <felipebalbi@...rs.sourceforge.net>
To:	"David Brownell" <david-b@...bell.net>
Cc:	"Felipe Balbi" <felipe.balbi@...ia.com>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: HAVE_CLK (for <linux/clk.h> support)

On Wed, May 28, 2008 at 2:14 AM, David Brownell <david-b@...bell.net> wrote:

[snip]

> --- g26.orig/drivers/usb/musb/Kconfig   2008-05-27 16:02:41.000000000 -0700
> +++ g26/drivers/usb/musb/Kconfig        2008-05-27 16:01:09.000000000 -0700
> @@ -8,7 +8,7 @@ comment "Enable Host or Gadget support t
>
>  # (M)HDRC = (Multipoint) Highspeed Dual-Role Controller
>  config USB_MUSB_HDRC
> -       depends on USB || USB_GADGET
> +       depends on HAVE_CLK && (USB || USB_GADGET)
>        select TWL4030_USB if MACH_OMAP_3430SDP
>        tristate 'Inventra Highspeed Dual Role Controller (TI, ...)'
>        help

Sorry, another comment.

Instead of making the driver dependant on HAVE_CLK (which would be
true for virtually any driver comming from linux-omap), you could make
clk_enable a nop in case arch doesn't HAVE_CLK. How does that sound?

-- 
Best Regards,

Felipe Balbi
felipebalbi@...rs.sourceforge.net
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/