linux-kernel - Re: RESEND: [PATCH 3/3] Misc: Add HP WMI laptop extras driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 29 May 2008 09:07:19 +0100
From:	Matthew Garrett <mjg59@...f.ucam.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-input@...r.kernel.org, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org, carlos@...angeworlds.co.uk
Subject: Re: RESEND: [PATCH 3/3] Misc: Add HP WMI laptop extras driver

On Wed, May 28, 2008 at 10:42:00PM -0700, Andrew Morton wrote:
> On Wed, 28 May 2008 14:34:25 +0100 Matthew Garrett <mjg59@...f.ucam.org> wrote:
> > --- /dev/null
> > +++ b/drivers/misc/hp-wmi.c
> 
> I see no Kconfig or Makefile updates.

Oops. Will resend.

> > +static struct key_entry hp_wmi_keymap[] = {
> > +	{KE_SW, 0x01, SW_DOCK},
> > +	{KE_KEY, 0x02, KEY_BRIGHTNESSUP},
> > +	{KE_KEY, 0x03, KEY_BRIGHTNESSDOWN},
> > +	{KE_KEY, 0x04, KEY_HELP},
> > +	{KE_END, 0}
> > +};
> 
> Could be made const.  hp_wmi_input_setup() already honours that,
> others will need tweaks.

Not if we want to be able to set the keymap, surely?
-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/