linux-kernel - Re: [patch 3/8] Make d_path() consistent across mount operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 Jun 2008 01:55:48 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	hch@...radead.org, linux-fsdevel@...r.kernel.org,
	viro@...IV.linux.org.uk, linux-kernel@...r.kernel.org,
	agruen@...e.de, jjohansen@...e.de
Subject: Re: [patch 3/8] Make d_path() consistent across mount operations

On Sun, Jun 01, 2008 at 10:38:35PM +0200, Miklos Szeredi wrote:
> > > The path that __d_path() computes can become slightly inconsistent when it
> > > races with mount operations: it grabs the vfsmount_lock when traversing mount
> > > points but immediately drops it again, only to re-grab it when it reaches the
> > > next mount point.  The result is that the filename computed is not always
> > > consisent, and the file may never have had that name. (This is unlikely, but
> > > still possible.)
> > > 
> > > Fix this by grabbing the vfsmount_lock for the whole duration of
> > > __d_path().
> > 
> > Looks good, and lock holding times shouldn't be a problem either.
> 
> Thanks for the review of this batch.
> 
> Can you please in the future either explicitly ACK or NACK?  Because I
> really wouldn't want any more of this "Looks good, but bla bla bla"
> and then NACKing the patch when I send it off to Andrew.

ACK for patches 1-3.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/