linux-kernel - Re: [2.6.26 patch] fat_valid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 09 Jun 2008 03:55:31 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	Adrian Bunk <bunk@...nel.org>
Cc:	S..$(D*..(Ba.$(D+;.(Blar Onur 
	<caglar@...dus.org.tr>, linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Frank Seidel <fseidel@...e.de>,
	Onur Küçük <onur@...dus.org.tr>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [2.6.26 patch] fat_valid_media() isn't for userspace

Adrian Bunk <bunk@...nel.org> writes:

> This function isn't part of the kernel<->userspace API and therefore 
> shouldn't have been added at this place.
>
> I'd suggest the patch below instead.

Yes. This is new one, so it shouldn't have any users of that.
Looks more better. Thanks.

Acked-by: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>

> Commit 73f20e58b1d586e9f6d3ddc3aad872829aca7743
> (FAT_VALID_MEDIA(): remove pointless test)
> wrongly added the new fat_valid_media() function
> to the userspace-visible part of include/linux/msdos_fs.h
>
> Move it to the part of include/linux/msdos_fs.h that is not exported to 
> userspace.
>
> Reported-by: Onur K.$(D+d+.+d.(Bk <onur@...dus.org.tr>
> Reported-by: S..$(D*..(Ba.$(D+;.(Blar Onur <caglar@...dus.org.tr>
> Signed-off-by: Adrian Bunk <bunk@...nel.org>
>
> ---
>
>  include/linux/msdos_fs.h |   12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> 4a56896ef4ef839cdc9d59fd7118c5051231c61e diff --git a/include/linux/msdos_fs.h b/include/linux/msdos_fs.h
> index b03b274..81cd36b 100644
> --- a/include/linux/msdos_fs.h
> +++ b/include/linux/msdos_fs.h
> @@ -57,12 +57,6 @@
>  #define MSDOS_DOT	".          "	/* ".", padded to MSDOS_NAME chars */
>  #define MSDOS_DOTDOT	"..         "	/* "..", padded to MSDOS_NAME chars */
>  
> -/* media of boot sector */
> -static inline int fat_valid_media(u8 media)
> -{
> -	return 0xf8 <= media || media == 0xf0;
> -}
> -
>  #define FAT_FIRST_ENT(s, x)	((MSDOS_SB(s)->fat_bits == 32 ? 0x0FFFFF00 : \
>  	MSDOS_SB(s)->fat_bits == 16 ? 0xFF00 : 0xF00) | (x))
>  
> @@ -334,6 +328,12 @@ static inline void fatwchar_to16(__u8 *dst, const wchar_t *src, size_t len)
>  #endif
>  }
>  
> +/* media of boot sector */
> +static inline int fat_valid_media(u8 media)
> +{
> +	return 0xf8 <= media || media == 0xf0;
> +}
> +
>  /* fat/cache.c */
>  extern void fat_cache_inval_inode(struct inode *inode);
>  extern int fat_get_cluster(struct inode *inode, int cluster,
>

-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/