lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 9 Jun 2008 11:05:12 +0300 From: Adrian Bunk <bunk@...nel.org> To: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp> Cc: "H. Peter Anvin" <hpa@...nel.org>, Adrian Bunk <bunk@...nel.org>, S.Çağlar Onur <caglar@...dus.org.tr>, linux-kernel@...r.kernel.org, Linus Torvalds <torvalds@...ux-foundation.org>, Frank Seidel <fseidel@...e.de>, Onur Küçük <onur@...dus.org.tr>, Andrew Morton <akpm@...ux-foundation.org> Subject: Re: [2.6.26 patch] fat_valid_media() isn't for userspace On Mon, Jun 09, 2008 at 01:12:37PM +0900, OGAWA Hirofumi wrote: > "H. Peter Anvin" <hpa@...nel.org> writes: > > > The other thing about this header that needs to be fixed is the > > definition of the following ioctls: > > > > #define VFAT_IOCTL_READDIR_BOTH _IOR('r', 1, struct dirent [2]) > > #define VFAT_IOCTL_READDIR_SHORT _IOR('r', 2, struct dirent [2]) > > > > "struct dirent" is a kernel type here, but is a **different type** in > > userspace! This means both the structure and the IOCTL number is wrong! > > > > We need to make this either __kernel_dirent_t[*] or something like > > struct __msdos_fs_dirent. > > I see. "struct dirent" in linux/dirent.h has very few users in kernel, > and probably userland doesn't use it, so it seems it should be renamed. > > Well, the patch is like this (sorry, other cleanup is in this patch)? >... I wanted to ask whether it could have had any users at all, but at least Wine contains a workaround for our bug... > Thanks. > > > -hpa >... > OGAWA Hirofumi <hirofumi@...l.parknet.co.jp> >... cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists