linux-kernel - Re: BUG: NULL pointer dereference at 00000000 -- IP: [<f8e783d5>] :b43:b43_dma_mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 11 Jun 2008 07:23:32 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Michael Buesch <mb@...sch.de>
CC:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>,
	vegard.nossum@...il.com, miles.lane@...il.com,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	linux-wireless@...r.kernel.org
Subject: Re: BUG: NULL pointer dereference at 00000000 -- IP: [<f8e783d5>]
 :b43:b43_dma_mapping_error+0x16/0x155

Michael Buesch wrote:
> On Wednesday 11 June 2008 02:58:44 FUJITA Tomonori wrote:
>> On Tue, 10 Jun 2008 16:50:26 +0200
>> Michael Buesch <mb@...sch.de> wrote:
>>
>>> On Tuesday 10 June 2008 16:42:41 Vegard Nossum wrote:
>>>> This change comes from
>>>>
>>>> commit 353c409463ecba63c3a41a992d3f5fba935eada9
>>>> Author: FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
>>>> Date:   Fri May 23 19:02:30 2008 +0000
>>>
>>> Ok, FUJITA Tomonori, please make sure a patch like the following goes
>>> into the same trees that you submitted commit 353c409 to.
>>> Also make sure to check b43legacy. I _guess_ you might have added
>>> the same bug there.
>> Ah, sorry about the bug.
>>
>> From a quick look, mainline needs the same fix too?
>>
>> b43_dma_mapping_error calls unmap_descbuffer() on the failure, which
>> assumes that ring->dev is set up properly.
> 
> Yeah ok. That's an unlikely error path.
> The new bug is in the main path which will always trigger.
> 
> Next time please send _any_ patch for review to me and to the wireless list.
> Please tell me which trees this bug has been merged to. Is it already in
> Linus' tree?

The equivalent line in Linus's tree is "if 
(unlikely(dma_mapping_error(addr)))", thus the error has not reached 
mainline (yet?).

Larry

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/